instedd / mbuilder

Scalable SMS application builder
http://mbuilder.instedd.org/
6 stars 1 forks source link

Validation triggers are not working #344

Closed nditada closed 8 years ago

nditada commented 8 years ago

Steps to reproduce:

  1. Create a trigger, create a "colors" table with a "name" column
  2. Store the message as a new value for that column.
  3. Right click on the column and setup a validation with 'red, yellow, blue'.
  4. Click on the validation trigger link
  5. Add a validation error message.
  6. Click 'save'.

Result: error message Expected: the trigger gets saved and the user is taken back to the previous trigger.

Note: I tried saving the first trigger before clicking on the validation trigger link, but that still results in an error when saving the new validation trigger.

381 and 349 are examples of final state: triggers list becomes unaccessible.

asterite commented 8 years ago

The problem seems to happen only in production because an icon is missing for the "Validation Triggers" section when there are no triggers. In development the error of an icon not found is silently ignored.

@jkicillof Could you design an icon for this? Similar to the ones for "Periodic Task" and "External Triggers", but for "Validation Triggers".

screenshot 2016-07-26 15 23 12

asterite commented 8 years ago

There's a separate issue that you can't create a validation trigger before creating a trigger with a table, and saving that table.

asterite commented 8 years ago

Oh, actually, there's no icon for that because the section is missing, but a method is invoked that still requires an asset... I'll just use an existing asset.

jkicillof commented 8 years ago

Use this icon from the platform icon set image

nditada commented 8 years ago

@asterite is this solved? can we close it?

asterite commented 8 years ago

Yes, closed :-)

I created an issue related to this one: #347