search

instedd / oasis

UCSD Oasis platform
5 stars 4 forks source link

Moving js function from Dashboard to Map #382

Open ste519 opened 3 years ago

ste519 commented 3 years ago

On branch feature/368-stories-widget: the task is to move all the js functions from frontend/src/routes/Dashboard/index.js to frontend/src/components/Map/index.js and resolve possible conflicts (this should be a good way to get familiar with the file structures and the stack).

MuhammadCF commented 3 years ago

Does my objective include only moving the components from one file to another and making sure that the will be no conflicts rising after or was there an inherent bug in the integration between the react render and the mapbox render (which might have necessitated this issue to begin with) that I have to take into account as well?

If my memory serves me well In the last meeting I attended (first week of the break), I have heard that there was some sort of dom conflict going on that compels this component-moving, but I forgot the specifics. @ste519

ste519 commented 3 years ago

Does my objective include only moving the components from one file to another and making sure that the will be no conflicts rising after or was there an inherent bug in the integration between the react render and the mapbox render (which might have necessitated this issue to begin with) that I have to take into account as well?

If my memory serves me well In the last meeting I attended (first week of the break), I have heard that there was some sort of dom conflict going on that compels this component-moving, but I forgot the specifics. @ste519

@MuhammadCF The task is basically moving the components and resolving conflicts. To debug for the rendering problem possibly due to dom conflict is optional, but I would recommend taking a look into it.

MuhammadCF commented 3 years ago

@ste519 Would it be okay to instead move the components from (frontend/src/components/Map/index.js) To (frontend/src/routes/Dashboard/index.js) i.e. the other way around?

another question: is it to be expected that I am neither able to login/sign up or visit as a guest in this branch (feature/368-stories-widget), or did I somewhat build it incorrectly?

yls00 commented 3 years ago

@ste519 Would it be okay to instead move the components from (frontend/src/components/Map/index.js) To (frontend/src/routes/Dashboard/index.js) i.e. the other way around?

another question: is it to be expected that I am neither able to login/sign up or visit as a guest in this branch (feature/368-stories-widget), or did I somewhat build it incorrectly?

@MuhammadCF I think it is because of database issue. Probably, your database did not set up. You should follow the every step in the readme, like ./dev-setup and then run docker.

yls00 commented 3 years ago

Not on the prioritization list anymore.