search

instedd / surveda

InSTEDD Surveda
https://instedd.org/technologies/surveda-mobile-surveys/
GNU General Public License v3.0
16 stars 6 forks source link

Questionnaires marked as complete with empty SMS parts #2328

Closed matiasgarciaisaia closed 2 months ago

matiasgarciaisaia commented 2 months ago

As of 0.37.2, a questionnaire with an SMS step consisting of two empty parts is marked as a correct/completed questionnaire - but it should be marked as incomplete if any SMS part is empty.

Both SMS parts of a step are empty, but the questionnaire is validated as correct

matiasgarciaisaia commented 2 months ago

Sending out an empty SMS is not correct (it's an error in at least some carriers, but probably on all of them). We should probably mark the questionnaire's step as incomplete if there's a correct SMS part and an empty one, but we may want to silently drop the empty part, too.