Open anaPerezGhiglia opened 4 months ago
We'd have to re-check, but we should probably only drop contact attempts with nil
channel state if the contact attempt is really old (for some definition of really old - maybe a couple of days).
I think there's a "standard" way to have contact attempts without channel state in the queue, and we shouldn't GC those - but only do so in cases like the one we had in staging, in which a contact attempt was left there for months.
We may even want to generalize this to an ultimate GC pass in which we drop old contact attempts regardless of everything else - like a forcefull GC that may leave some stuff inconsistent but will always work (ie, it won't check if there's a contact attempt queued in the channel).
Clear the channel broker queue entry if
active_contact.channel_state
is nil to prevent the following error