Add base url setting to twilio channels

bcardiff commented 3 years ago

🎯 The task

De-hardcode the Twilio base URL. Let the user set it for every channel.

🥕 The motivation

The main reasons are:

Twilio can have multiple endpoints. Having an only URL for all Twilio channels prohibits users from taking advantage of that.
Surveda (instedd/surveda#1793) needs an IVR stress test tool and it could take the shape of a fake Twilio endpoint that uses the new setting.

🚧 Tasks:

[x] Add base_url to twilio channel
[x] When blank use the default https://api.twilio.com/2010-04-01
[x] Add it in rails forms
[x] Pick up from erlang the base_url of the current twilio channel
[x] (Optional) add it in pigeon screens (used as iframes for Surveda)

matiasgarciaisaia commented 2 years ago

See #896 - there's an issue on production while running this feature, so I've reverted it. @ysbaddaden provided some insights. Let's properly review, test and deploy a solution instead of doing that now in a hurry.

ysbaddaden commented 1 year ago

@matiasgarciaisaia can you test that the problem you originaly had doesn't happen anymore? The base url failing when undefined if I recall correctly?

matiasgarciaisaia commented 1 year ago

I've just tested 656fb0d28ec83d0779a9e4f01beb50aeafda80e5 in staging with no TWILIO_BASE_URL environment variable set, and it worked OK 👍

instedd / verboice