instedd / verboice

Open source toolkit for voice services; with special focus to the needs of medium- and low-income countries, scalable services, and interacting with vulnerable populations
http://verboice.instedd.org/
GNU General Public License v3.0
43 stars 18 forks source link

Revert "Add base url setting to twilio channels (#879)" #896

Closed matiasgarciaisaia closed 2 years ago

matiasgarciaisaia commented 2 years ago

The broker is failing in production due to some issues trying to determine Twilio's Base URL. The PR included some logic to default the URL if it was not explicitly given, but it seems to be bogus. We should rework this feature at some time - but for the time being, let's avoid having bogus code in the master branch.

Reverts instedd/verboice#879 See #878

matiasgarciaisaia commented 2 years ago

Yes!

[info] [<0.4953.1>|fa145569] session: Session ("3527d32c-1004-47a0-b67e-484f9ed7eee9") dial
[warning] [<0.4953.1>|fa145569] session: Session ("3527d32c-1004-47a0-b67e-484f9ed7eee9") terminated with reason: {badarg,[{erlang,'++',[undefined,"/Accounts/"],[]},{twilio_broker,dispatch,1,[{file,"src/twilio/twilio_broker.erl"},{line,31}]},{session,ready,3,[{file,"src/session/session.erl"},{line,216}]},{gen_fsm,handle_msg,7,[{file,"gen_fsm.erl"},{line,503}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,237}]}]}
[error] [<0.4953.1>|undefined] unknown_module: gen_fsm {session,[51,53,50,55,100,51,50,99,45,49,48,48,52,45,52,55,97,48,45,98,54,55,101,45,52,56,52,102,57,101,100,55,101,101,101,57]} in state ready terminated with reason: bad argument in call to erlang:'++'(undefined, "/Accounts/") in twilio_broker:dispatch/1 line 31
[error] [<0.4953.1>|undefined] unknown_module: CRASH REPORT Process <0.4953.1> with 0 neighbours exited with reason: bad argument in call to erlang:'++'(undefined, "/Accounts/") in twilio_broker:dispatch/1 line 31 in gen_fsm:terminate/7 line 611
[error] [<0.145.0>|undefined] unknown_module: Supervisor session_sup had child "3527d32c-1004-47a0-b67e-484f9ed7eee9" started with {session,start_link,undefined} at <0.4953.1> exit with reason bad argument in call to erlang:'++'(undefined, "/Accounts/") in twilio_broker:dispatch/1 line 31 in context child_terminated