search

instedd / verboice

Open source toolkit for voice services; with special focus to the needs of medium- and low-income countries, scalable services, and interacting with vulnerable populations
http://verboice.instedd.org/
GNU General Public License v3.0
44 stars 18 forks source link

Fix: use isActive in Africa's Talking notifications #904

Closed ysbaddaden closed 2 years ago

ysbaddaden commented 2 years ago

This should hopefully fix the session state issues we're having with Africa's Talking channels.

fixes #902

ysbaddaden commented 2 years ago

CI is broken because we can't install Ruby's activesupport gem v3.2 in the erlang image. Bundler complains that the ruby version is unsupported?

ysbaddaden commented 2 years ago

Part of it is true: the erlang docker image is based on Debian Jessie which only ships Ruby 2.1 but the activesupport 3.2.22 gem requires Ruby 1.8.7 not Ruby 2.2 :confused:

errata: the problem is the concurrent-ruby gem. This is fixed with gem install concurrent-ruby -v 1.1.9.

ysbaddaden commented 2 years ago

Now the problem is that the Erlang dependencies use the unauthenticated git:// protocol that GitHub removed support for some months ago. This is a simple fix: just replace git:// with https://, and we can fix the direct dependencies, as well as indirect dependencies from instedd, but we're powerless with other dependencies, who do use the git:// protocol!

matiasgarciaisaia commented 2 years ago

I'm publishing a preview image so we can actually test this in the relevant Surveda environment.

matiasgarciaisaia commented 2 years ago

I've just tried a call that yielded "No answer", and it was correctly marked as finished in Verboice.

We'll run a couple of tests soon, and I'll try to review the code while we're on that.

ysbaddaden commented 2 years ago

@matiasgarciaisaia GitHub automatically changes the base branch: merge #905 first and this PR will be changed to target main master.

matiasgarciaisaia commented 2 years ago

Well, I had to not only manually update the base branch, but also rebase it manually 😅

It may have to do with the fact that I've squash-merged #905 instead of doing a git merge - idk.

I'll merge this since it looks OK and it's strictly better than what we already have - which is broken.