instill-ai / instill-core

🔮 Instill Core is a full-stack AI infrastructure tool for data, model and pipeline orchestration, designed to streamline every aspect of building versatile AI-first applications
https://www.instill.tech
Other
2.16k stars 107 forks source link

[Video] Video Component to extract 1 frame every N seconds #1115

Closed ShihChun-H closed 1 month ago

ShihChun-H commented 2 months ago

Issue Description

Current State

Why We Want to Change?

Proposed Change


Rules for the Component Hackathon


Component Contribution Guideline | Documentation | Official Go Tutorial

samir-advantech commented 1 month ago

I am interested in this issue @ShihChun-H

ShihChun-H commented 1 month ago

@samir-advantech Awesome! Let me assign this issue to you. Please make sure to read and follow the rules above 🙌🏻

ShihChun-H commented 1 month ago

Hi @samir-advantech, I'm following up to check on any progress made regarding this issue. Could you please provide an update? Thanks 🙏

Reckadon commented 1 month ago

Hi, @ShihChun-H ! If @samir-advantech is not available or working on this, can I work on this?

kuroxx commented 1 month ago

Hey @samir-advantech, since this issue has not been worked on for over >5 days, I will now assign this issue to @Reckadon 🙏 Thank you for your contribution attempt!

Reckadon commented 1 month ago

hi @kuroxx, thanks for letting me contribute. I have managed to setup the project but am facing error while building the instill-core. It is related to influxdb dependency failed to start: container influxdb exited (1)

kuroxx commented 1 month ago

Hey @Reckadon, thanks for raising the issue!

I saw your message on Discord - hope it can be resolved after adjusting the Docker resources : https://www.instill.tech/docs/core/deployment#docker-resource-requirements

Reckadon commented 1 month ago

do we want to accept inputs like 10, 30, 1/5, 1/10 only or, are pure numbers fine? like- 10, 30, 0.2, 0.1, 0.5

accepting both numbers and fractional strings will require the type field in tasks.json to be any.

chuang8511 commented 1 month ago

do we want to accept inputs like 10, 30, 1/5, 1/10 only or, are pure numbers fine? like- 10, 30, 0.2, 0.1, 0.5

It seems good that we can support 1/5 or 0.2.

accepting both numbers and fractional strings will require the type field in tasks.json to be any.

Yes, please proceed this. Thanks for confirmation!

Reckadon commented 1 month ago

@chuang8511 but the main issue is can the type field be any, I think only specific types like number or string are supported

chuang8511 commented 1 month ago

Oh, I did not notice it. Could you try to set it as string first?

Reckadon commented 1 month ago

Setting it as string causes an error when u pass in a pure number like 10 from the frontend. It's because the JSON parser treats it as a number and does not convert it to a number string (10 and not "10"). I think allowing only numbers (integers and floats) and not strings is the only feasible option for now. Let me know if I can do something to change the behaviour of the Parser.

Reckadon commented 1 month ago

opened a PR to close this issue

kuroxx commented 1 month ago

@chuang8511 @donch1989 please review when you are free 🙏 thank you!