search

institut-de-genomique / Ultimate-DataTable

This AngularJS directive generate a HTML table with build-in fonctionnality like save, edit, remove, pagination etc...
http://institut-de-genomique.github.io/Ultimate-DataTable/
45 stars 26 forks source link

Messy white space #20

Open ghost opened 8 years ago

ghost commented 8 years ago

I can see that you have some issues with shared code style. Some of you use TAB, others double space. Any chance to get that tided up? Would you like to get pull request with clean formatted code and Eslint rules? I'm using double space and few "easy-to-read" concepts for Angular specific stuff notation.

image

BTW. I very much appreciate your work! API is good, SOC is also nice.

galbini commented 8 years ago

Yes, thanks for your help. The Eslint rules can be integrated with grunt to format automatically the code ?

ghost commented 8 years ago

Unfortunately no. But those rules can be used for pre-commit pr pre-merge check. I'm also using them right inside my IDE to spot problems right away.

ydeshayes commented 8 years ago

@galbini I can install ESlint and refactor if you want. We can try to migrate the code the ES6, but we'll need to install more tool to downgrade to ES5 when we're shipping.

galbini commented 8 years ago

@ydeshayes, good idea for the refactoring but i prefer to wait to have validate your pull request before refactor all the code because the merge will be hard in the other sense.

The upgrade to ES6 can be planned after the next release.