search

instride-ch / omnipay-datatrans

Omnipay Datatrans
MIT License
1 stars 8 forks source link

Undefined property: Omnipay\Datatrans\Message\XmlResponse::$httpRequest #3

Closed fredtro closed 6 years ago

fredtro commented 6 years ago

Hi there

Using XmlGateway results in an error. Is it possible that:

public function getData( { return $this->httpRequest->request->all(); }

Should be:

public function getData( { return $this->data; }

Thank you

dpfaffenbauer commented 6 years ago

possible, have you tested it? Does it work? We actually don't use the XML Gateway...

fredtro commented 6 years ago

Yes, it will return the array version of the xml result/response. Should i create a pull request?

dpfaffenbauer commented 6 years ago

sounds good to me 👍

fredtro commented 6 years ago

Perfect. Additionally i have notices that datatrans service urls are outdated (https://www.datatrans.ch/en/technology_apis/important-changes). But i will create another pull request for it, so you just have to hit ok 😬

dpfaffenbauer commented 6 years ago

ok :)

fredtro commented 6 years ago

I close this issue due to merged pull request which fixed it.