search

instride-ch / pimcore-data-definitions

Data Definitions Plugin for Pimcore
Other
77 stars 58 forks source link

fix: configure csv writer's escape character to be an empty string by default #375

Closed slri closed 1 year ago

slri commented 1 year ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #374

Updates CsvProvider to set escape character as an empty string for the writer, see original issue.

dpfaffenbauer commented 1 year ago

@dkarlovi WDYT?

dkarlovi commented 1 year ago

IMO, it's OK to allow this via config, but it's not a good default since it might break current use cases.

I'd say we want this to be configurable.

dpfaffenbauer commented 1 year ago

@slri can you make that configurable?

slri commented 1 year ago

@dpfaffenbauer i agree with the points and would have made it configurable from the get go if i had time for it. i'll do it over the weekend.

slri commented 1 year ago

Took a while to get to it, but it's finally done. @dpfaffenbauer @dkarlovi please review.

dpfaffenbauer commented 1 year ago

fine by me @dkarlovi WDYT?