instride-ch / pimcore-data-definitions

Data Definitions Plugin for Pimcore
Other
77 stars 58 forks source link

Memoize \Wvision\Bundle\DataDefinitionsBundle\Fetcher\ObjectsFetcher::getClassListing #376

Closed dkarlovi closed 1 year ago

dkarlovi commented 1 year ago
Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Branch? master

Currently, the listing is constructed each time from scratch. Because Pimcore is swallowing exceptions, you can get a random "Class not found" exception in the middle of your export.

Since context cannot change during the run (not like the class will change), we should be able to safely just memoize the listing.

dkarlovi commented 1 year ago

Closed in #379