search

instride-ch / pimcore-data-definitions

Data Definitions Plugin for Pimcore
Other
78 stars 58 forks source link

[Perf] cache \Wvision\Bundle\DataDefinitionsBundle\Interpreter\AssetUrlInterpreter::deduplicateAsset #401

Closed dkarlovi closed 1 year ago

dkarlovi commented 1 year ago
Q A
Bug report? no
Feature request? yes
BC Break report? no
RFC? no
Branch? master

With a lot of assets, doing an asset-heavy import can run this query thousands of times, and since it's using LIKE, it can be slow. We should cache the output if an asset is found so we can speed up the process.

dkarlovi commented 1 year ago

This doesn't work well enough, we should actually change how we store the URL instead and remove LIKE %URL%.