search

instructlab / community

InstructLab Community wide collaboration space including contributing, security, code of conduct, etc
Apache License 2.0
71 stars 40 forks source link

update installation #251

Closed celek closed 2 months ago

celek commented 4 months ago

https://github.com/instructlab/instructlab/ has a newer getting started

russellb commented 4 months ago

Maybe we should just remove this file completely and replace all references to the instructlab/instructlab README ?

celek commented 4 months ago

Maybe we should just remove this file completely and replace all references to the instructlab/instructlab README ?

i am ok with that - at least , as a new user, I can test that my ilab generate and ilab train work ? Should we then

jjasghar commented 4 months ago

Yep, this document was supposed to be the "quick start" without all the fluff around what you need to do. It was the basis for the lab we did at summit to get people to install and "go".

explain how to create a PR

No, we shouldn't do this, we should reference the official GitHub documentation, because it will change, and that's just more over head for us. And also this isn't what this document is for.

explain how remove that PR (so not all new user submit the same PR) ?

This is another official GitHub document, we shouldn't have to rewrite this out, we should point to the best practices of GitHub.

nathan-weinberg commented 2 months ago

@celek do you intend to revisit this PR?