Closed russellb closed 6 days ago
LGTM as well.
Minor bit feedback that is non-blocking: should we notify elsewhere than just oversight committee that team membership has changed? I think this may be overkill but an FYI only post in #admin in InstructLab Slack is also likely useful for communicating well and widely. My .02 EUR.
LGTM as well.
Minor bit feedback that is non-blocking: should we notify elsewhere than just oversight committee that team membership has changed? I think this may be overkill but an FYI only post in #admin in InstructLab Slack is also likely useful for communicating well and widely. My .02 EUR.
sounds reasonable, depending on the nature of the change.
We have had a couple recent cases where a member of the oversight committee saw a need for adjustments to team membership and made those changes without going through the formalities discussed in our CONTRIBUTOR_ROLES document.
We believe that is acceptable at this early stage of the project. Update the document to make it clear that this is an expected and approved part of our governance at this time.
Signed-off-by: Russell Bryant rbryant@redhat.com