search

instructlab / dev-docs

Developer documents for the InstructLab organization
Apache License 2.0
2 stars 27 forks source link

Changes to CLI commands #100

Open rafvasq opened 3 months ago

rafvasq commented 3 months ago

Design doc to amend the work started in https://github.com/instructlab/instructlab/pull/1022.

The current implementation is a good start. I see that ilab init takes a workspace path and when specified, it will ensure that the directory exists. I would like to get a more complete UX for the feature before we merge anything, though. I think it would be easiest to write out a design for the spec of the changes to CLI commands before implementing it. We can try doing that just in comments here, or if it gets too difficult, it can be a design doc posted to https://github.com/instructlab/dev-docs.

A starting point would be my original comment here: https://github.com/instructlab/instructlab/pull/1022#pullrequestreview-2027422480

To summarize - once a workspace is created and configured, I'd like to see everything done relative to that workspace instead of the current working directory. Otherwise, it feels incomplete and not enough of an improvement over mkdir workspace ; cd workspace.

Originally posted by @russellb in https://github.com/instructlab/instructlab/issues/1022#issuecomment-2140541840

Also related: https://github.com/instructlab/instructlab/issues/1034

github-actions[bot] commented 4 weeks ago

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.