search

instructlab / dev-docs

Developer documents for the InstructLab organization
Apache License 2.0
4 stars 32 forks source link

Introduce ilab model standards across CLI and libraries #131

Closed alinaryan closed 2 months ago

alinaryan commented 2 months ago

Introduce standardizing how models are stored, managed, and accessed via flags used in CLI tools and libraries to ensure consistency, usability, and maintainability.

RobotSail commented 2 months ago

I really like the changes proposed in this PR. It seems like we just need to change the functionality so we do:

  1. If a model path matches against an OCI directory, first check if that exists
  2. Check if the provided path matches against a file (doing os.path.exists(model_path) will cover both the absolute & relative path case)
  3. If it didn't match, check against the output of ilab model list

It also sounds like we need to extract the logic that's currently in ilab model list and make it globally available, so that way we can achieve consistent behavior across the project.

It also sounds like we'll need to do the same for the data we generate

jaideepr97 commented 2 months ago

what do we need to get this dev doc merged? its been sitting for a while