Propose allowing repositories to require more than one reviewer

instructlab / dev-docs

Developer documents for the InstructLab organization

Apache License 2.0

4 stars 31 forks source link

Propose allowing repositories to require more than one reviewer #36

Closed khaledsulayman closed 6 months ago

khaledsulayman commented 6 months ago

Funnily enough, we also need to require approvals here 😂

I vote 2, depending on what comes out of this PR, of course.

russellb commented 6 months ago

Funnily enough, we also need to require approvals here 😂

Yeah, the README defines a very loose definition of what approvals should be considered before merging as it varies depending on the content.

russellb commented 6 months ago

As written, I don't find this PR controversial for merging. In other words, I don't think it needs to stay open an extended time for review. A couple of approvals seems fine. It doesn't change a policy. It just clarifies that a given maintainer team may impose additional requirements as they feel is appropriate for a given repo.