instructlab / dev-docs

Developer documents for the InstructLab organization
Apache License 2.0
4 stars 31 forks source link

Define policy for adding or updating Python dependencies #77

Open tiran opened 5 months ago

tiran commented 5 months ago

We should create a policy and guiding document how to deal with new dependencies or updates of existing dependencies.

Some thoughts:

leseb commented 5 months ago

I like the idea. Additionally, is it worth running an inspection of the current deps as well and see if some could be removed too?

bjhargrave commented 5 months ago

Most of the repos other than instructlab have dependabot keeping dependencies up-to-date. Eventually we need to add dependabot to the instructlab certainly for the workflows but also for the python dependencies.

russellb commented 5 months ago

Most of the repos other than instructlab have dependabot keeping dependencies up-to-date. Eventually we need to add dependabot to the instructlab certainly for the workflows but also for the python dependencies.

Yes! I've been meaning to look at this, but haven't gotten around to it. It would be great if you were interested in working on this at some point!

bjhargrave commented 5 months ago

It would be great if you were interested in working on this at some point!

It is on my dance card 🕺

nathan-weinberg commented 5 months ago

We also need to ensure any dependencies that are added are compliant from a licensing POV - @mrutkows is our resident expert on that AFAIK :smile:

github-actions[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.