search

instructlab / instructlab-bot

GitHub bot to assist with the taxonomy contribution workflow
Apache License 2.0
14 stars 16 forks source link

Create Status max character of 140 #206

Closed nerdalert closed 4 months ago

nerdalert commented 4 months ago

I'm definently missing some context on swapping to client.Repositories.CreateStatus vs client.Issues.CreateComment switch for the messaging of a couple of commands. After hacking around for a while in not being able to post to a private fork with CreateStatus I reverted to comment but noticed the max character limitation of 140 when trying to add the S3 url back into https://github.com/instruct-lab/instruct-lab-bot/blob/8cd71c2fe11d10f4747b2a6950cffccd8be97301/gobot/bot/bot.go#L231

Guessing you all hit the limitation as to why it's left empty. Just raising an issue to track the plan. Wonder if we can set the status without a message followed by a CreateComment. Ty!

bot     | 2024-04-12T05:26:46.759Z  ERROR   bot/bot.go:236  Failed to update pull request status: POST https://api.github.com/repos/nerdalert/taxonomy/statuses/ffe2ee08c2f35dcfc66fc66ead7f93f8ae5e68ae: 422 Validation Failed [{Resource:Status Field:description Code:custom Message:description is too long (maximum is 140 characters)}]
nerdalert commented 4 months ago

TargetURL is the s3 link so we won't hit max chars 🎉