Create unique indexes with jobID/hash/prNum

instructlab / instructlab-bot

GitHub bot to assist with the taxonomy contribution workflow

Apache License 2.0

14 stars 16 forks source link

Create unique indexes with jobID/hash/prNum #238

Closed nerdalert closed 4 months ago

nerdalert commented 4 months ago

Prepares us for multi-worker and removes listing all jobs in triage results. More details in the issues.

Closes #235 Closes #236

nerdalert commented 4 months ago

Example index files from the same PR with two generates run:

https://brent-instruct-lab-dev.s3.us-east-1.amazonaws.com/sdg-svc-pr-6-ffe2ee08c2f35dcfc66fc66ead7f93f8ae5e68ae-job-2/index.html

https://brent-instruct-lab-dev.s3.us-east-1.amazonaws.com/sdg-svc-pr-6-ffe2ee08c2f35dcfc66fc66ead7f93f8ae5e68ae-job-3/index.html

vishnoianil commented 4 months ago

@nerdalert LGTM ty!

Once suggestion, it would be helpful if we can add job number in the index file heading as well, just to make it more convenient (rather than finding it in url).