instructlab / instructlab-bot

GitHub bot to assist with the taxonomy contribution workflow
Apache License 2.0
13 stars 16 forks source link

URL not found in readme #279

Closed matteopulcini6 closed 3 months ago

matteopulcini6 commented 3 months ago

Hi Team,

At the top of the readme.md for instructlab-bot the URL in the second sentence URL under enhancement document results in a 404 error, is your team able to check this?

i.e., More detail on how this bot fits into the overall architecture is being captured in this enhancement document.

jjasghar commented 3 months ago

https://github.com/instructlab/enhancements/blob/main/docs/github-taxonomy-automation.md this link seems ok to me?

matteopulcini6 commented 3 months ago

@jjasghar @khaledsulayman The URL I am referring to is https://github.com/instructlab/enhancements/blob/main/docs/github-taxonomy-automation.md it gives me a 404, likely a permission issue, not sure if this was an expectation.

nerdalert commented 3 months ago

Thanks @matteopulcini6! It does point to a org members private repo. @jjasghar are there plans to open that repo or should we adjust?

vishnoianil commented 3 months ago

@matteopulcini6 it seems okay to me. I assume you are talking about this one

Screenshot 2024-04-19 at 11 54 14 AM
vishnoianil commented 3 months ago

@matteopulcini6 it seems okay to me. I assume you are talking about this one

Screenshot 2024-04-19 at 11 54 14 AM

@matteopulcini6 never mind, it's pointing to private repo as brent mentioned, hence the 404. we will look into it. Thanks for reporting!

khaledsulayman commented 3 months ago

@nerdalert yes currently it is a private repo that we are planning on opening up eventually

russellb commented 3 months ago

addressed in https://github.com/instructlab/instructlab-bot/pull/281

vishnoianil commented 3 months ago

addressed in #281

Thanks for taking care of it @russellb