search

instructlab / instructlab-bot

GitHub bot to assist with the taxonomy contribution workflow
Apache License 2.0
12 stars 15 forks source link

Add a status kay to jobs in the redis queue #303

Closed nerdalert closed 2 months ago

nerdalert commented 2 months ago

This will cleanly map to grafana views. Also before popping the job off the queue, the worker needs to set the state to running.

russellb commented 2 months ago

This will cleanly map to grafana views. Also before popping the job off the queue, the worker needs to set the state to running.

Original reply

This won't work. Once you pop it, it's not there anymore. This is one reason I was interested in moving to Streams -- https://github.com/instructlab/instructlab-bot/issues/109

NEVERMIND - I'm wrong. I remember now that we store the job separately and just queue up job IDs. Carry on. Although I still like the idea of using Streams!

nerdalert commented 2 months ago

Resolved with #313