search

instructlab / instructlab-bot

GitHub bot to assist with the taxonomy contribution workflow
Apache License 2.0
12 stars 15 forks source link

add open-all link #310

Closed Gregory-Pereira closed 1 month ago

Gregory-Pereira commented 2 months ago

Addresses #246

Gregory-Pereira commented 2 months ago

After testing, I found that a common behaviour for all modern ad-blockers is to disable multiple page opens for the obvious reasons. While I cannot (easily) interact with the your specific browser's settings directly from the agnostic HTML script tag, I can add an alert informing the user of this behaviour that is not immediately apparent under the hood. If you open the console tag and check errors, you should have a quick way to navigate to unblocking the ad-blocker for that subdomain + domain combo, in this case: https://instruct-lab-bot.s3.us-east-2.amazonaws.com/. Worked for me running Chrome v124.0.6367.91 arm

Knowing this, do we still want this feature @jjasghar

Gregory-Pereira commented 2 months ago

As outcome of standup, maybe make this more into a single file, but have a bunch of next buttons which would use anchor tags to route to the next entry...

vishnoianil commented 2 months ago

@Gregory-Pereira here is the very raw mockup of what i was thinking of:

Screenshot 2024-04-29 at 11 33 20 PM

We can create one html file, and put content from these yaml files as a frame/slide. Reviewer can press the arrow and it can go to the next set of input (context, question) and answer. That way they don't have to jump between the files and can review all the results through single tab. We can make it even bit more smarter, by not putting all the contents in the html itself, but use script to read these files and display them pretty-print.

Let me know if you have any other suggestion or if you want to take a stab at it, otherwise i can give it a shot.

Gregory-Pereira commented 2 months ago

I am happy to go forward with this implementation.

vishnoianil commented 2 months ago

I am happy to go forward with this implementation.

Awesome, feel free to ping me if you need any help with this

Gregory-Pereira commented 1 month ago

Partially resolved in #340. The rest has been moved to #346.