Closed nerdalert closed 5 months ago
@mingxzhao have we opened a bug in instructlab yet? I will pop one if not. I can replicate the bug with just the cli. I had left it as is in the patch.
Example:
[root@f27bd496fb8f data]# /usr/local/bin/ilab chat --quick-question can you solve the following riddle? Two turkeys in front of the turkey, two turkeys behind the turkey, tell me how many total turkeys? --context HOTDOGS HAMBURGERS PANCAKES
INFO 2024-05-02 20:30:58,031 chat.py:479 Context HOTDOGS not found in the config file. Using default.
Only reluctance to patch it is when it gets fixed upstream there will be a float period but since this is time sensitive I'll add a buffer word. If you can help us track it we can hopefully not break for long when it gets fixed. Ty!
No no bug opened yet, and I will keep an eye out for a fix when merged.
fmt.Sprintf
instead of arg slicing.--quick-question
works fine with slice construction but--context
does not.Closes #306