instructlab / instructlab-bot

GitHub bot to assist with the taxonomy contribution workflow
Apache License 2.0
12 stars 15 forks source link

Add yaml download option #387

Closed nerdalert closed 2 weeks ago

nerdalert commented 4 weeks ago

@mingxzhao at your convenience, will you give this a spin on this dev instance here. Might be helpful to add a popup with an example of a full skill/knowledge if you have examples of quality submissions for each. This doesn't validate the fields like the web form submit. Can reuse Anil's nice checks, just want to see if the formatting here is proper first. I used the v2 schema for ref.

mingxzhao commented 3 weeks ago

Looking good, a few things: user should have option to add more qna pairs as needed, default download file name for yaml should be qna.yaml, also download for attribution.txt would also be nice as current attribution form seems to just toss it into the ether? We can sync monday to iron out but great stuff so far.

nerdalert commented 3 weeks ago

@mingxzhao good call on the QnA pairs. Added it. Also got a PoC for direct pulls going on a test repo.

  1. Fork the test repo. It should work without the user needing to fork it as well but I haven't tested.
  2. Hit the UI this dev ui here and log back in via Oauth (clear cache). You will notice new permissions being requested which are very broad atm. Need to narrow them down which I think is doable but atm it is repo access in the token. Also added an attribution download and attribution file to the submission. Submissions will get created to this test repo, not taxonomy so fire off as many as you like for testing/debugging. Ty.
nerdalert commented 2 weeks ago

This has moved to the UI project.