search

instructlab / schema

JSON schema for Taxonomy YAML
Apache License 2.0
0 stars 7 forks source link

schema package: Build a python package with the schema #27

Closed bjhargrave closed 2 weeks ago

bjhargrave commented 3 weeks ago

This will allow schema users to pip install the schema instead of using something like git submodules to place the schema files at some local path.

bjhargrave commented 3 weeks ago

@tiran Can you review the changes here to build a python package for the schema? The goal is to replace using git submodules (as we currently do) with a python dependency.

tiran commented 3 weeks ago

I'm happy to help. However I have very limited available until Jun 18th due to travel and other commitments.

bjhargrave commented 3 weeks ago

@russellb @nathan-weinberg Can either of you look at this PR? I would like to get it in (we can always sort out any issues with PyPI packaging later; the publish steps are "falsed" out now). Then other projects like the cli and taxonomy can move to use the package via a pip git+ url to this repo.

I have PRs in cli (https://github.com/instructlab/instructlab/pull/1285) and taxonomy (https://github.com/instructlab/taxonomy/pull/1169), to demonstrate accessing the schema via an installed package is working.

bjhargrave commented 3 weeks ago

I created a pending publisher for instructlab-schema as documented in https://docs.pypi.org/trusted-publishers/creating-a-project-through-oidc/.