search

instructlab / sdg

Python library for Synthetic Data Generation
Apache License 2.0
5 stars 13 forks source link

ci: add action for python linting and formatting #12

Closed nathan-weinberg closed 3 weeks ago

nathan-weinberg commented 3 weeks ago

Implemented this locally in #7 but missed this action

nathan-weinberg commented 3 weeks ago

Only CI failure here is due to #6

bjhargrave commented 3 weeks ago

We should also add the mypy step from https://github.com/instructlab/instructlab/pull/1235 once it is completed.

tiran commented 3 weeks ago

You also need to add a py.typed marker file to src/instructlab/sdg, so the parent package knows that the subpackage uses type annotations. https://peps.python.org/pep-0561/#packaging-type-information

nathan-weinberg commented 3 weeks ago

We should also add the mypy step from instructlab/instructlab#1235 once it is completed.

As part of this PR or as a followup?

You also need to add a py.typed marker file to src/instructlab/sdg, so the parent package knows that the subpackage uses type annotations. https://peps.python.org/pep-0561/#packaging-type-information

That path doesn't exist - do you mean src/instructlab_sdg? What should this file look like?

nathan-weinberg commented 3 weeks ago

@bjhargrave since the MyPy PR merged in the other repo I went ahead and added it to this PR