search

instructlab / sdg

Python library for Synthetic Data Generation
Apache License 2.0
5 stars 13 forks source link

offshoot gen_test_data() from very long generate_data() #15

Closed makelinux closed 6 days ago

makelinux commented 3 weeks ago

Function generate_data is huge and messy.

Refactor it.

russellb commented 3 weeks ago

Thank you for posting the PR to this repo!

The changes look good, though it would make my life a little easier if I hold off on merging it until I can remove the original code from instructlab/instructlab. I'm hoping that's done this week.

russellb commented 1 week ago

Thanks for the updates.

The changes look good, though it's highlighting the lack of integration testing in this repo. I'm going to look into that now.

russellb commented 6 days ago

I got an e2e workflow enabled on this repo in #33. I'm going to rebase this PR to trigger it to run.

russellb commented 6 days ago

@Mergifyio rebase

mergify[bot] commented 6 days ago

rebase

✅ Branch has been successfully rebased