search

instructlab / sdg

Python library for Synthetic Data Generation
Apache License 2.0
5 stars 13 forks source link

Wrap read_taxonomy from instructlab.utils #21

Closed russellb closed 2 weeks ago

russellb commented 2 weeks ago

This is a hack to get tests passing back in instructlab/instructlab. There is a test there that tries to mock read_taxonomy, but it's not working because of how we use it. This hack gives a place the test can mock.

The real issue here is that the split of code between instructlab and sdg is a mess and these dependencies in both directions both in code and in the tests. There's a lot of work to clean this up, but I'm just trying to get to a functional starting point.

Signed-off-by: Russell Bryant rbryant@redhat.com

russellb commented 2 weeks ago

Trying to get this done quickly so I'm just merging ... ping me if you see anything I broke