search

instructlab / sdg

Python library for Synthetic Data Generation
Apache License 2.0
5 stars 13 forks source link

requirements.txt: Move instructlab to requirements-dev.txt #28

Closed russellb closed 1 week ago

russellb commented 1 week ago

70335a1 requirements.txt: instructlab to requirements-dev.txt

commit 70335a140f9036a135fa228165c4964695a37912 Author: Russell Bryant rbryant@redhat.com Date: Tue Jun 18 21:26:12 2024 -0400

requirements.txt: instructlab to requirements-dev.txt

This is still a dependency, but it's causing some problems in
`instructlab` repo CI. A released version of instructlab gets
installed first because of this entry, then it has to be uninstalled
before the development version can be installed.

The currently released version of `instructlab` still has schema
embedded. The next release (and current `main`) uses the
`instructlab-schema` package. Moving from one to the other in tox
is breaking the schema package.

By moving it, it will still be installed for local repo testing
purposes.

This should solve the CI failures seen here:
https://github.com/instructlab/instructlab/pull/1244

Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb commented 1 week ago

This is a trivial change that's blocking the CLI change to use the library, so I'm just going to merge it.

Once we get to a working initial state, I won't do merges like this.