search

instructlab / ui

Place to hack on UI for InstructLab
Apache License 2.0
11 stars 23 forks source link

Integrate storage component to the UI stack #13

Open vishnoianil opened 3 months ago

Gregory-Pereira commented 2 months ago

Could we provide some more context here, I have no clue what this is 😂 . Do we mean just PVCs in the deployment manifests?

vishnoianil commented 2 months ago

@Gregory-Pereira my bad, this is to integrate the data storage (postgres or something better) with the UI stack to store the UI related metadata. To start with, it's mostly for caching github data, but eventually we need to ensure that all the user generate data (depends on the new feature we plan to implement in future) that we can't store in github is stored in the database. For the release-1.0, it's not critical so i put it on back-burner, but something we should start thinking about it.

Gregory-Pereira commented 2 months ago

Awesome, thanks for the clarity. Lets bump this tag to release-1.1 so we know its not a release blocker. I would love to dig into what we mean by metadata here, would be caching user knowledge contribution data? User data that is used in multiple places such as user email? We can bevel this out later but for now just going to move the tag and close my PR.