search

instructlab / ui

Place to hack on UI for InstructLab
Apache License 2.0
15 stars 38 forks source link

Added spinner to file upload in knowledge section #276

Closed nikhil-krajput closed 4 weeks ago

nikhil-krajput commented 1 month ago
vishnoianil commented 1 month ago

@nikhil-krajput can you please signoff the commit to make the DCO job happy. If you click the "Details" link, it should give you the instructions on how to sign-off your commits.

vishnoianil commented 1 month ago

@nikhil-krajput Lint job is failing as well. Locally run the npm run lint:fix, and it should fix your linting error.

nikhil-krajput commented 1 month ago

@nikhil-krajput Lint job is failing as well. Locally run the npm run lint:fix, and it should fix your linting error.

@vishnoianil I have added the signed commits and fixed the lint error as well

vishnoianil commented 1 month ago

@nikhil-krajput PR looks good to me, but the commit history looks weird on your PR. Can you sync your git fork and pull the new changes in your local fork on your machine and rebase this PR, and that should fix your commit history.

vishnoianil commented 4 weeks ago

@nikhil-krajput looks like the commit history is still not fixes. Ping me one slack, happy to help with this.

vishnoianil commented 4 weeks ago

Raised PR #301 after fixing git commit history.