search

instructlab / ui

Place to hack on UI for InstructLab
Apache License 2.0
15 stars 38 forks source link

Bump @patternfly/react-core from 5.4.1 to 6.0.0 #318

Closed dependabot[bot] closed 2 weeks ago

dependabot[bot] commented 2 weeks ago

Bumps @patternfly/react-core from 5.4.1 to 6.0.0.

Commits
  • 69e2057 chore(release): releasing packages [ci skip]
  • 952cafc Update promote.sh [ci skip]
  • 3dccaee Update promote.sh [ci skip]
  • 4ce551e Update README.md
  • 02e0579 chore(release): releasing packages [ci skip]
  • f19a7a5 fix(Menus): added new fix for scroll jump bug (#11119)
  • e6c87a6 chore(release): releasing packages [ci skip]
  • 2b2bc35 fix(Select/Dropdown): updated autofocus to false by default in v6 (#11115)
  • 09a8f38 fix(charts): update Victory packages to be optional peer dependencies (#11128)
  • a3ffb39 Revert "chore(deps): update dependency rollup to ^4.24.0 (#11084)" (#11101)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 2 weeks ago

The following labels could not be found: npm dependencies, frontend.

nerdalert commented 2 weeks ago

Closing this as it breaks quite a bit, particularly with the Text import. Will open an issue for a PF v6 bump.

Here is a quick type-check of breakage:

3 import { Text } from '@patternfly/react-core/dist/dynamic/components/Text';
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/app/login/githublogin.tsx:4:29 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

4 import { TextContent } from '@patternfly/react-core/dist/dynamic/components/Text';
                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/app/login/githublogin.tsx:138:13 - error TS2322: Type '{ children: Element; variant: ModalVariant.medium; title: string; titleIconVariant: string; isOpen: true; onClose: () => void; actions: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.
  Property 'titleIconVariant' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.

138             titleIconVariant="warning"
                ~~~~~~~~~~~~~~~~

src/app/login/page.tsx:66:68 - error TS2322: Type '{ children: Element; href: string; onClick: () => void; linkComponentProps: { 'aria-label': string; }; }' is not assignable to type 'IntrinsicAttributes & LoginMainFooterLinksItemProps'.
  Property 'linkComponentProps' does not exist on type 'IntrinsicAttributes & LoginMainFooterLinksItemProps'.

66     <LoginMainFooterLinksItem href="#" onClick={handleGitHubLogin} linkComponentProps={{ 'aria-label': 'Login with Github' }}>
                                                                      ~~~~~~~~~~~~~~~~~~

src/app/playground/chat/page.tsx:9:67 - error TS2305: Module '"@patternfly/react-core/"' has no exported member 'TextContent'.

9 import { Breadcrumb, BreadcrumbItem, PageBreadcrumb, PageSection, TextContent, TextInput, Title } from '@patternfly/react-core/';
                                                                    ~~~~~~~~~~~

src/app/playground/endpoints/page.tsx:14:30 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/next/components/Modal' or its corresponding type declarations.

14 import { ModalVariant } from '@patternfly/react-core/dist/dynamic/next/components/Modal';
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/app/playground/endpoints/page.tsx:15:45 - error TS2305: Module '"@patternfly/react-core/components/"' has no exported member 'TextContent'.

15 import { Breadcrumb, BreadcrumbItem, Modal, TextContent } from '@patternfly/react-core/components/';
                                               ~~~~~~~~~~~

src/app/playground/endpoints/page.tsx:186:13 - error TS2322: Type '{ children: Element; title: string; isOpen: true; onClose: () => void; variant: any; actions: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.
  Property 'actions' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'. Did you mean 'action'?

186             actions={[
                ~~~~~~~

src/components/AboutModal/AboutModal.tsx:2:49 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

2 import { Text, TextContent, TextVariants } from '@patternfly/react-core/dist/dynamic/components/Text';
                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/AppLayout.tsx:7:49 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

7 import { Text, TextContent, TextVariants } from '@patternfly/react-core/dist/dynamic/components/Text';
                                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/AppLayout.tsx:140:34 - error TS2769: No overload matches this call.
  Overload 1 of 2, '(props: NavProps): Nav', gave the following error.
    Type '{ children: Element; id: string; theme: Theme; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Nav> & Pick<Readonly<NavProps>, never> & InexactPartial<...> & InexactPartial<...>'.
      Property 'theme' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Nav> & Pick<Readonly<NavProps>, never> & InexactPartial<...> & InexactPartial<...>'.
  Overload 2 of 2, '(props: NavProps, context: any): Nav', gave the following error.
    Type '{ children: Element; id: string; theme: Theme; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Nav> & Pick<Readonly<NavProps>, never> & InexactPartial<...> & InexactPartial<...>'.
      Property 'theme' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Nav> & Pick<Readonly<NavProps>, never> & InexactPartial<...> & InexactPartial<...>'.

140     <Nav id="nav-primary-simple" theme={theme}>
                                     ~~~~~

src/components/AppLayout.tsx:148:18 - error TS2322: Type '{ children: Element; theme: Theme; }' is not assignable to type 'IntrinsicAttributes & PageSidebarProps'.
  Property 'theme' does not exist on type 'IntrinsicAttributes & PageSidebarProps'.

148     <PageSidebar theme={theme}>
                     ~~~~~

src/components/AppLayout.tsx:157:36 - error TS2322: Type '{ children: ReactNode; mainContainerId: string; header: Element; isManagedSidebar: true; sidebar: Element; skipToContent: Element; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Page> & Pick<Readonly<PageProps>, never> & InexactPartial<...> & InexactPartial<...>'.
  Property 'header' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Page> & Pick<Readonly<PageProps>, never> & InexactPartial<...> & InexactPartial<...>'. Did you mean 'headers'?

157     <Page mainContainerId={pageId} header={Header} isManagedSidebar sidebar={Sidebar} skipToContent={PageSkipToContent}>
                                       ~~~~~~

src/components/Contribute/Knowledge/DocumentInformation/DocumentInformation.tsx:245:9 - error TS2322: Type '{ children: Element; variant: ModalVariant.medium; title: string; titleIconVariant: string; isOpen: boolean; onClose: () => void; actions: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.
  Property 'titleIconVariant' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.

245         titleIconVariant="warning"
            ~~~~~~~~~~~~~~~~

src/components/Contribute/Knowledge/index.tsx:22:29 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

22 import { TextContent } from '@patternfly/react-core/dist/dynamic/components/Text';
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/Contribute/Knowledge/UploadFile.tsx:165:11 - error TS2322: Type '{ children: Element; isOpen: boolean; title: string; titleIconVariant: string; variant: "small"; "aria-label": string; onClose: () => void; actions: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.
  Property 'titleIconVariant' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.

165           titleIconVariant="warning"
              ~~~~~~~~~~~~~~~~

src/components/Contribute/Skill/index.tsx:20:29 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

20 import { TextContent } from '@patternfly/react-core/dist/dynamic/components/Text';
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/Dashboard/index.tsx:16:10 - error TS2305: Module '"@patternfly/react-core/dist/dynamic/components/EmptyState"' has no exported member 'EmptyStateHeader'.

16 import { EmptyStateHeader } from '@patternfly/react-core/dist/dynamic/components/EmptyState';
            ~~~~~~~~~~~~~~~~

src/components/Dashboard/index.tsx:26:29 - error TS2307: Cannot find module '@patternfly/react-core/dist/esm/components/Text/TextContent' or its corresponding type declarations.

26 import { TextContent } from '@patternfly/react-core/dist/esm/components/Text/TextContent';
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/Experimental/ContributeLocal/Knowledge/index.tsx:22:29 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

22 import { TextContent } from '@patternfly/react-core/dist/dynamic/components/Text';
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/Experimental/ContributeLocal/Skill/index.tsx:20:29 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

20 import { TextContent } from '@patternfly/react-core/dist/dynamic/components/Text';
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/Experimental/DashboardLocal/index.tsx:16:3 - error TS2305: Module '"@patternfly/react-core/dist/dynamic/components/EmptyState"' has no exported member 'EmptyStateHeader'.

16   EmptyStateHeader,
     ~~~~~~~~~~~~~~~~

src/components/Experimental/DashboardLocal/index.tsx:195:24 - error TS2322: Type '"light"' is not assignable to type '"default" | "secondary" | undefined'.

195           <PageSection variant="light">
                           ~~~~~~~

  node_modules/@patternfly/react-core/dist/esm/components/Page/PageSection.d.ts:19:5
    19     variant?: 'default' | 'secondary';
           ~~~~~~~
    The expected type comes from property 'variant' which is declared here on type 'IntrinsicAttributes & PageSectionProps'

src/components/GithubAccessPopup/index.tsx:39:7 - error TS2322: Type '{ children: Element; variant: ModalVariant.medium; title: string; titleIconVariant: string; isOpen: boolean; onClose: () => void; actions: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.
  Property 'titleIconVariant' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.

39       titleIconVariant="warning"
         ~~~~~~~~~~~~~~~~

src/components/UserMenu/ThemePreference.tsx:2:36 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/components/Text' or its corresponding type declarations.

2 import { Text, TextVariants } from '@patternfly/react-core/dist/dynamic/components/Text';
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/YamlCodeModal/index.tsx:5:30 - error TS2307: Cannot find module '@patternfly/react-core/dist/dynamic/next/components/Modal' or its corresponding type declarations.

5 import { ModalVariant } from '@patternfly/react-core/dist/dynamic/next/components/Modal';
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/components/YamlCodeModal/index.tsx:24:7 - error TS2322: Type '{ children: Element; variant: any; title: string; isOpen: boolean; onClose: () => void; "aria-label": string; actions: Element[]; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'.
  Property 'actions' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes<Modal> & Pick<Readonly<ModalProps>, "children"> & InexactPartial<...> & InexactPartial<...>'. Did you mean 'action'?

24       actions={[
         ~~~~~~~

Found 27 errors in 17 files.
dependabot[bot] commented 2 weeks ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.