instructlab / ui

Place to hack on UI for InstructLab
Apache License 2.0
15 stars 38 forks source link

remove combining tags steps and restructure multiple tags #346

Closed Gregory-Pereira closed 4 days ago

Gregory-Pereira commented 4 days ago

Previous workflow failed, see logs: https://github.com/instructlab/ui/actions/runs/11862220666/job/33061144701#step:13:213.

The issue here was that the extracted tag data from one of the "${{ steps.ghcr_ui_meta.outputs.tags }}" values resolves to something like quay.io/instructlab-ui/pathservice:main where as the combined tags got only the image tag, resolving to pr-334. This is why it would complain because it thinks the whole image ref was pr-334 and so it couldn't build. I have refactored my approach to the tagging which I think should work, and refactored for simplicity.

cc @vishnoianil @nerdalert