instructlab / ui

Place to hack on UI for InstructLab
Apache License 2.0
15 stars 38 forks source link

[FIX] Migrate from environment specific secrets to repo specific secrets #365

Open Gregory-Pereira opened 1 day ago

Gregory-Pereira commented 1 day ago

Unless we are doing this (having secrets only available to the main and release-1.0 branches), I would like to move secrets to be available on all upstream branches. If we are concerned about security, we can limit those who create upstream branches with the following settings: Restrict who can push to matching branches, and Restrict pushes that create matching branches. Why would this be valuable? This means that If I am fixing something in CI, we can test it on an open PR without having to merge it to main. This is will be important as we group to help remove downtime. Here is a perfect example of where this might be useful for testing: #364

Happy to take this on if we agree with the idea @vishnoianil and @nerdalert