instructlab / ui

Place to hack on UI for InstructLab
Apache License 2.0
8 stars 16 forks source link

Improve submission table #99

Open Misjohns opened 1 month ago

Misjohns commented 1 month ago

The table should include a toolbar with search filter, primary button to indicate the most important action, and pagination or item count to give users more navigational capability. Use a more prominent label treatment to draw attention to it or make it more searchable. Group row actions together and reduce the prominence of the Edit buttons.

Reference: https://www.patternfly.org/components/table/design-guidelines https://www.patternfly.org/components/toolbar/design-guidelines https://www.patternfly.org/components/label/design-guidelines

@beaumorley

Misjohns commented 1 month ago

What are the labels we should expose on the submissions table? Knowledge, skills, others?

Misjohns commented 1 month ago

What actions should a user be able to take on a submission? View PR, edit submission, delete submission, others?

Misjohns commented 1 month ago

Submission table design

image

Misjohns commented 1 month ago

Changes to the actions menu: Remove Duplicate Add "View in GitHub" to menu and remove "View PR" from table rows ( UX to research the best terms for following actions: View in GitHub, Delete submission)

States: Team will make a decision for the best terms via slack.

Once these items are finalized UX will update design and move issue to Ready

Misjohns commented 1 month ago

@vishnoianil Maybe we should add Download YAML and Download Attribution in the actions menu? Thoughts?

vishnoianil commented 1 month ago

e we should add Download YAML and Download Attribution

I think adding these options to action menu makes sense to me. Just to give some more context around these options - The reason to add Download YAML was for user to use the generated yaml and create the knowledge/skill PR by themselves. Just an alternate way for github savvy devs to use github interface, but avoid all yaml related challenges.

Misjohns commented 1 week ago

@nerdalert Updated designs image image image