The master branch contains a commit (98da4407) to add a version property to package.json so that it can be used with yarn workspaces in Canvas. This commit is missing from the stable branch, so Canvas installations that pull from stable instead of master can't build.
Steps to reproduce:
Clone canvas-lms/stable
Clone analytics/stable into gems/plugins/analytics
bundle install, yarn install
bundle exec rake canvas:compile_assets
Expected behaviour
Canvas should build
Actual behaviour
yarn will throw a warning and not install the analytics gem's dependencies: warning Missing version in workspace at "/path/to/canvas/gems/plugins/analytics", ignoring.. Later on, the webpack build will fail because of missing dependencies in analytics:
ERROR in ./gems/plugins/analytics/app/coffeescripts/graphs/base.coffee
Module not found: Error: Can't resolve 'graphael' in '/path/to/canvas/gems/plugins/analytics/app/coffeescripts/graphs'
@ ./gems/plugins/analytics/app/coffeescripts/graphs/base.coffee 1:0-207:2
@ ./gems/plugins/analytics/app/coffeescripts/graphs/grades.coffee
@ ./gems/plugins/analytics/app/coffeescripts/Course/CourseView.coffee
@ ./gems/plugins/analytics/app/coffeescripts/bundles/course.coffee
ccutrer
commented
6 years ago
The
masterbranch contains a commit (98da4407) to add aversionproperty to package.json so that it can be used with yarn workspaces in Canvas. This commit is missing from thestablebranch, so Canvas installations that pull fromstableinstead ofmastercan't build.Steps to reproduce:
Expected behaviour
Actual behaviour
yarnwill throw a warning and not install the analytics gem's dependencies:warning Missing version in workspace at "/path/to/canvas/gems/plugins/analytics", ignoring.. Later on, the webpack build will fail because of missing dependencies in analytics: