search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.44k stars 2.43k forks source link

Deleted enrollments without sis_batch_id are not visible in the provisioning report #1385

Open StefSchenkelaars opened 5 years ago

StefSchenkelaars commented 5 years ago

Summary:

Enrollments created and deleted through the UI (and thus have no sis_batch_id) are not visible in the provisioning report. The enrollment is still accessible through the API and has the deleted workflow state so that all makes sense.

This is the responsible line of code. Therefore it looks like this is done on purpose but there is no test that covers this case.

Steps to reproduce:

  1. Create a course with enrollment through the UI (to make sure it has no sis_id)
  2. Delete / unenroll the enrollment
  3. Create a provisioning report on the account and check enrollments and include_deleted
  4. Verify that the enrollment is not in the list

Expected behavior:

Enrollments without sis_batch_id are also included in the provisioning report.

Actual behavior:

Enrollments without sis_batch_id are not included in the provisioning report.

Additional notes:

So I am not 100% sure that this is actually a bug or if it is a feature but for our use case of just fetching all enrollments, it does not make sense.

stale[bot] commented 3 years ago

Thanks for contributing to this issue. As it has been 2 years since the last activity, we are automatically closing the issue in 30 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please respond before the issue is closed, or post a message on the mailing list. We'll gladly take a look again!