search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.55k stars 2.47k forks source link

Canvas LTI 'launch_presentation_document_target' always set to 'iframe' #1427

Open adamrabung opened 5 years ago

adamrabung commented 5 years ago

Summary:

Canvas allows the educator to choose whether to launch LTI external tools in an iframe or as a new window. Some LTI external tools may behave different based on this choice. LTI specifies 'launch_presentation_document_target' as a recommended property for informing the external tool of this choice, but Canvas always sends the value 'iframe'. Please consider sending 'window' for this field when the user chooses to launch external tools in a new window.

Steps to reproduce:

  1. Create a new assignment with "Submission Type" set to "External Tool". Be sure to select 'Load This Tool In A New Tab' when configuring Submission Type
  2. Launch this assignment and inspect the LTI payload. Note that Canvas sends 'launch_presentation_document_target' -> 'iframe'.

Expected behavior:

When the assignment is loaded in a new window, Canvas should 'launch_presentation_document_target' -> 'window'

Actual behavior:

Canvas sends 'launch_presentation_document_target' -> 'iframe'

Additional notes:

scalebig commented 5 years ago

Seeing the same in our LTI Tool Provider

kpommerenke commented 3 years ago

This is the issue with the most upvotes (12 as of 8/31/2021) and still hasn't been fixed or even assigned since 2019: https://github.com/instructure/canvas-lms/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc