instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.55k stars 2.47k forks source link

No Friendly Forwarding Eportfolio page with comments #1433

Open fred-bict opened 5 years ago

fred-bict commented 5 years ago

Summary: No Friendly Forwarding Eportfolios with comments if user not logged in.

Steps to reproduce:

Expected behavior: After recipient has logged in, Canvas does some 'Friendly Forwarding' back to Eportfolio-URL.

Actual behavior: After recipient has logged in, Canvas shows Dashboard (recipient) .

Additional notes: See File: app/views/eportfolios/show.html.erb Code lines: 412-415

Now I override this code lines with: session[:return_to] = clean_return_to(uri) and some javascript. But of course I prefer the controller, to do this.

stale[bot] commented 2 years ago

Thanks for contributing to this issue. As it has been 2 years since the last activity, we are automatically closing the issue in 30 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please respond before the issue is closed, or post a message on the mailing list. We'll gladly take a look again!