search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.46k stars 2.44k forks source link

Student ePub exports fail silently for concluded courses #1458

Open christopher-b opened 5 years ago

christopher-b commented 5 years ago

Summary:

On the ePub export page (https://your.canvas.com/epub_exports), concluded courses are listed, but trying to generate an export fails with no user feedback.

Steps to reproduce:

  1. Enroll as a student in a concluded course
  2. Try to generate an ePub export of that course.
  3. Watch the JS console for an authorization error

Expected behavior:

Either the exported should be generated, or feedback should be provided to users stating that they cannot generate ePubs for concluded courses.

Actual behavior:

The export fails, with no feedback to the user.

Additional notes:

The problem lies here: https://github.com/instructure/canvas-lms/blob/e5b47766209cc534923ff67758d0350458997d6a/app/models/epub_export.rb#L85

Students cannot "participate" in concluded courses. I think this should be modified to allow students who can read the course to generate the export

course.grants_right?(user, :read)
stale[bot] commented 3 years ago

Thanks for contributing to this issue. As it has been 2 years since the last activity, we are automatically closing the issue in 30 days. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please respond before the issue is closed, or post a message on the mailing list. We'll gladly take a look again!

christopher-b commented 3 years ago

I believe this issue is still present. Thanks.

anish-kondepudi commented 1 year ago

I'm also seeing this issue.

AbelSuperstar100 commented 1 month ago

Tried to export ePub from a recently archived course. Issue is still present.