instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.71k stars 2.52k forks source link

Submitted At value from LTI Results passback is not shown/used on speed grader #1705

Open dobesv opened 4 years ago

dobesv commented 4 years ago

Summary:

When using LTI grade passback with a submittedAt value, the gradebook will reflect the "late" status of the grade according to the value received, but in speed grader it shows the submissions as LATE based on the time the grade was passed back.

Steps to reproduce:

  1. Set yourself up for LTI grade passback somehow
  2. Pass back a grade with submittedAt set to a date in the past
  3. Set the assignment due date between the submittedAt date and the time the grade was passed back using LTI replaceResult
  4. Check whether the grade shows as late (green) in the gradebook
  5. Check whether the submission shows as late in speed grader

Expected behavior:

Speed grader and the gradebook should use the provided submittedAt value to determine whether the submission was late, not the time the grade was passed back.

Actual behavior:

Speed grader reports submissions as LATE, which confuses teachers.

Additional notes:

Feel free to contact me

jennifermannBSD commented 3 years ago

I though this was resolved last year but still seems to be an issue...