search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.6k stars 2.48k forks source link

New LTI launch sizing issue #2052

Closed claydiffrient closed 2 years ago

claydiffrient commented 2 years ago

Summary:

New LTI assignment launches show in a squished view and scroll within the iframe on the page. This also happens when we modify existing assignment launches that aren't broken (prior to ~1.5 weeks ago). Removing the custom_height class from the iframe makes the problem go away.

Steps to reproduce:

  1. Create an assignment using an LTI tool (Derivita in our case)
  2. Launch the assignment
  3. Notice that it's squished

Expected behavior:

Screen Shot 2022-04-27 at 12 08 31 PM

Actual behavior:

Screen Shot 2022-04-27 at 12 07 31 PM

Additional notes:

As far as we can tell we've done nothing different on our side to make this behavior happen. Our LTI launches are happening the same as always.

stephendgilbert commented 2 years ago

This has happened to us as well. Viewing the source of the generated pages, the LTI-launch iframe now has this style: style="height:px;width:px" Prior to about two weeks ago, the style was: style="height:100%;width:100%"

stephendgilbert commented 2 years ago

A fix was committed for this on May 3rd and seems to work for us.