search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.45k stars 2.44k forks source link

Side Scroll Bar #2109

Closed sprintup closed 1 year ago

sprintup commented 1 year ago

Summary:

image

Steps to reproduce:

1. 2. 3.

Expected behavior:

Actual behavior:

Additional notes:

Ardena commented 1 year ago

What are you expecting? It looks like you're assuming there shouldn't be a scroll bar, but there are a lot of items in that list, so they just wouldn't show without a scroll bar.

sprintup commented 1 year ago

Hi! I added the scrollbar using the dev tools. There is not a scrollbar in production and I tried to find where to add the related css properties shown in the screenshot, but it seems to be too complicated to submit a PR myself. It seems like I have to sign something, familiarize myself with this project's processes, then figure out how the documentation is built, which is a bit much. If you can point me in the right direction, I can submit a PR, but this is for work, so my boss is not going to be super enthusiastic about me spending time on another code base. @Ardena

Ardena commented 1 year ago

Just looked at the page and you're right that there's no scrollbar on the side bar, but the main scrollbar scrolls the whole sidebar, so I'm not sure why you'd want to add another scrollbar. Plus extra scrollbars like that can be hard for assistive technologies to use.