instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.43k stars 2.43k forks source link

add non-null check #2139

Closed qq7 closed 1 year ago

eschiebel commented 1 year ago

good catch. We will make this change in-house which will get reflected here once merged. I will also take the opportunity to build the URL in a more robust way than string concatenation, just in cast attachment.canvadoc_session_url itself includes an origin. Will reference the commit and close this PR when that's done.

jakeoeding commented 1 year ago

@qq7 We just merged a fix yesterday for this: https://github.com/instructure/canvas-lms/commit/9bbb37354d1bc6644b6f93c25bd44048f1043297