search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.58k stars 2.48k forks source link

Scrolling Past File Viewer Modal #2151

Open GeorgeBerdovskiy opened 1 year ago

GeorgeBerdovskiy commented 1 year ago

Summary

When viewing files in Canvas, users are able to not only scroll inside the modal but in the whole page as well. This hides the modal.

Steps to Reproduce

  1. Click on a file (for example - a PDF) link embedded into any page on Canvas
  2. Either drag the rightmost scrollbar or scroll with your mouse beyond the bottom of the page to move the whole modal up

Expected Behavior

While the file modal is open, the user should only be able to scroll inside the modal.

Actual Behavior

The user is able to scroll the page behind the modal, sliding the file viewer up.

Additional Notes

Here are some screenshots of the issue. If nobody minds, I'd love to take a shot at fixing this!

Screenshot 2023-01-31 at 5 45 56 PM Screenshot 2023-01-31 at 5 46 10 PM