instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.42k stars 2.42k forks source link

Update updated_at on sis batch when progress is updated #2188

Closed cgravatt closed 1 year ago

cgravatt commented 1 year ago

When the progress is updated on an sis batch via fast_updated_progress the updated_at field should also be updated.

The updated_at field is useful when monitoring when an import might be hung. For example, progress hasn't incremented since x time. Currently, as far as i've observed the updated_at value never progresses during the cleanup batch phase.

Test plan

jstanley0 commented 1 year ago

@cgravatt thanks for the submission. I had to tweak it slightly since the interpolation into sql caught the attention of our sql injection scanner, even though the interpolation was already there and none of the values are under user control anyway

cgravatt commented 1 year ago

Makes sense. Thanks @jstanley0