search

instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.42k stars 2.42k forks source link

Not following the LTI 1.3 spec #2201

Open davey4 opened 1 year ago

davey4 commented 1 year ago

Summary:

Currently in the login request the parameter of deployment_id is passed when the lti 1.3 spec states that it should be lti_deployment_id https://www.imsglobal.org/spec/lti/v1p3#lti_deployment_id-login-parameter

Steps to reproduce:

  1. Start a request
  2. See that it is deployment_id

Expected behavior:

Should be lti_deployment_id

Actual behavior:

Is deployment_id

Additional notes:

Possibly pass both so that it follows the lti 1.3 spec and continues current compatibility?