instructure / canvas-lms

The open LMS by Instructure, Inc.
https://github.com/instructure/canvas-lms/wiki
GNU Affero General Public License v3.0
5.42k stars 2.42k forks source link

Modal width is not responsive even if the width is changed in developer setting for external LTI tool when places in course assignment menu #2233

Open Soumyaranjanpal opened 11 months ago

Soumyaranjanpal commented 11 months ago

I want to place my LTI tool in the "Course Assignment Menu". Whenever I launch my LTI tool from the assignment Menu, the modal height and width are not changing even if I am modifying that while adding my LTI tool in the developer keys.

temp

This is how it looks after integrating. The width is not increasing even if I am increasing the width in developer keys as well as if forcing the LTI tool FE to have a greater min width value.

image

xandroxygen commented 11 months ago

as I mentioned in the IRC chat:

it looks like that modal should respect your launch dimensions but the request to get the tool info and dimensions is cached. I did just confirm that changing the width and height does change the modal size, but I had to check Disable Cache in the browser dev tools Network tab to make it show up. Also, your screenshot of your developer key looks correct.

let me know if this helps you out!

Soumyaranjanpal commented 11 months ago

Hi @xandroxygen , thank you for responding.

I have already tried that. The tool dimensions are working in the assignment selection view for the same LTI tool during deep linking.

But when I am placing the LTI tool in the course assignment menu, then the width/height changes are not reflected.

Just to check, I changed the Text to "Question Bank 2" from "Question Bank and change the height and width. But during launch, only the text change is observed but the width and height are still the same. So I was wondering, is it happening only when I am trying to place the tool in the course assignment menu?

image

After changing this is the result, where there is no change in width or height.

image